feat: add remark-lint-no-consecutive-blank-lines#18
Merged
Trott merged 2 commits intonodejs:masterfrom Sep 5, 2019
Merged
Conversation
Trott
reviewed
Sep 5, 2019
index.js
Outdated
| [require("remark-lint-strong-marker"), "*"], | ||
| [require("remark-lint-table-cell-padding"), "padded"] | ||
| [require("remark-lint-table-cell-padding"), "padded"], | ||
| [require("remark-lint-no-consecutive-blank-lines")] |
Member
There was a problem hiding this comment.
I think the rules are all in alphabetical order. Can you move this to where it belongs alphabetically?
(Probably makes sense to add a comment about this. Feel free to do that too if you want.)
Member
Author
There was a problem hiding this comment.
Does't look like they were totally sorted, but it makes sense so I did that in a separate commit
Trott
approved these changes
Sep 5, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM, although I'd prefer the rule moved in the list to be alphabetical.
nschonni
force-pushed
the
remark-lint-no-consecutive-blank-lines
branch
from
cb0648f to
83fca26
Compare
richardlau
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be OK with nodejs/node#29352, but I'm not sure if there are other affected repos that might also need to be checked/fixed before this can land